[ 
https://issues.apache.org/jira/browse/GOBBLIN-2134?focusedWorklogId=930494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-930494
 ]

ASF GitHub Bot logged work on GOBBLIN-2134:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Aug/24 00:20
            Start Date: 16/Aug/24 00:20
    Worklog Time Spent: 10m 
      Work Description: arjun4084346 commented on code in PR #4029:
URL: https://github.com/apache/gobblin/pull/4029#discussion_r1719144854


##########
gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/proc/KillDagProcTest.java:
##########
@@ -215,8 +216,6 @@ public void killDagNode() throws IOException, 
URISyntaxException, InterruptedExc
             .getInvocations()
             .stream()
             .filter(a -> a.getMethod().getName().equals("cancelJob"))
-            .filter(a -> ((Properties) a.getArgument(1))

Review Comment:
   the first job was launched, but we are cancelling the 3rd job, so the 
cancelParams will not have  "SPEC_PRODUCER_SERIALIZED_FUTURE". this is realized 
when i fixed the test mock behavior above





Issue Time Tracking
-------------------

            Worklog Id:     (was: 930494)
    Remaining Estimate: 0h
            Time Spent: 10m

> update job status to SKIPPED for all the dependent jobs of a cancelled job
> --------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2134
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2134
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Arjun Singh Bora
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to