[
https://issues.apache.org/jira/browse/GOBBLIN-2134?focusedWorklogId=934357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-934357
]
ASF GitHub Bot logged work on GOBBLIN-2134:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Sep/24 20:21
Start Date: 11/Sep/24 20:21
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on code in PR #4049:
URL: https://github.com/apache/gobblin/pull/4049#discussion_r1755536308
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -116,7 +116,7 @@ public abstract class KafkaJobStatusMonitor extends
HighLevelConsumer<byte[], by
private static final List<ExecutionStatus> ORDERED_EXECUTION_STATUSES =
ImmutableList
.of(ExecutionStatus.COMPILED, ExecutionStatus.PENDING,
ExecutionStatus.PENDING_RESUME, ExecutionStatus.PENDING_RETRY,
- ExecutionStatus.ORCHESTRATED, ExecutionStatus.RUNNING,
ExecutionStatus.COMPLETE,
+ ExecutionStatus.ORCHESTRATED, ExecutionStatus.RUNNING,
ExecutionStatus.SKIPPED, ExecutionStatus.COMPLETE,
Review Comment:
these four are the terminal statuses and once a job reaches here, further
GTEs can be ignored.
we also do not expect to see two of them for the same job.
yes, there can be some combinations of events among these four, that may
arrive due to race condition, but i think, in that case, it is ok for GaaS to
just adhere to any of the ordering. I do not want to change the correct
ordering, so I added SKIPPED before other terminal statuses, to basically
support the same idea of yours - let it show complete if it is
cancelled/skipped earlier.
Issue Time Tracking
-------------------
Worklog Id: (was: 934357)
Time Spent: 2h (was: 1h 50m)
> update job status to SKIPPED for all the dependent jobs of a cancelled job
> --------------------------------------------------------------------------
>
> Key: GOBBLIN-2134
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2134
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
