[
https://issues.apache.org/jira/browse/GOBBLIN-2137?focusedWorklogId=931274&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-931274
]
ASF GitHub Bot logged work on GOBBLIN-2137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Aug/24 06:27
Start Date: 22/Aug/24 06:27
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4032:
URL: https://github.com/apache/gobblin/pull/4032#discussion_r1726416565
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/MysqlDagStateStoreWithDagNodes.java:
##########
@@ -195,13 +195,14 @@ private Dag<JobExecutionPlan>
convertDagNodesIntoDag(Set<Dag.DagNode<JobExecutio
}
@Override
- public int updateDagNode(DagManager.DagId parentDagId,
Dag.DagNode<JobExecutionPlan> dagNode) throws IOException {
+ public int updateDagNode(DagManager.DagId parentDagId,
Dag.DagNode<JobExecutionPlan> dagNode, boolean isFailedDag) throws IOException {
Review Comment:
This implies that we are marking dagNode failures at parent level. Is that
the intended behaviour?
Issue Time Tracking
-------------------
Worklog Id: (was: 931274)
Time Spent: 1h 50m (was: 1h 40m)
> Merge Failed Node Dag State Store and Dag Node State Store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2137
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2137
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Merge Failed Node Dag State Store and Dag Node State Store
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
