[
https://issues.apache.org/jira/browse/GOBBLIN-2137?focusedWorklogId=936490&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-936490
]
ASF GitHub Bot logged work on GOBBLIN-2137:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/24 22:55
Start Date: 25/Sep/24 22:55
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4032:
URL: https://github.com/apache/gobblin/pull/4032#discussion_r1776075605
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -54,7 +54,7 @@ public ResumeDagProc(ResumeDagTask resumeDagTask, Config
config) {
@Override
protected Optional<Dag<JobExecutionPlan>> initialize(DagManagementStateStore
dagManagementStateStore)
throws IOException {
- return dagManagementStateStore.getFailedDag(getDagId());
+ return dagManagementStateStore.getDag(getDagId());
Review Comment:
verify the one returned is actually failed?
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ResumeDagProc.java:
##########
@@ -54,7 +54,7 @@ public ResumeDagProc(ResumeDagTask resumeDagTask, Config
config) {
@Override
protected Optional<Dag<JobExecutionPlan>> initialize(DagManagementStateStore
dagManagementStateStore)
throws IOException {
- return dagManagementStateStore.getFailedDag(getDagId());
+ return dagManagementStateStore.getDag(getDagId());
Review Comment:
shall we verify the one returned is actually failed?
Issue Time Tracking
-------------------
Worklog Id: (was: 936490)
Time Spent: 2h 20m (was: 2h 10m)
> Merge Failed Node Dag State Store and Dag Node State Store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2137
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2137
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Aditya Pratap Singh
> Priority: Minor
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Merge Failed Node Dag State Store and Dag Node State Store
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
