phet commented on code in PR #4031: URL: https://github.com/apache/gobblin/pull/4031#discussion_r1744202007
########## gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManagementTaskStreamImpl.java: ########## @@ -78,32 +76,19 @@ public class DagManagementTaskStreamImpl implements DagManagement, DagTaskStream private final Config config; @Getter private final EventSubmitter eventSubmitter; protected MultiActiveLeaseArbiter dagActionProcessingLeaseArbiter; - protected Optional<DagActionReminderScheduler> dagActionReminderScheduler; - private final boolean isMultiActiveExecutionEnabled; + protected DagActionReminderScheduler dagActionReminderScheduler; private static final int MAX_HOUSEKEEPING_THREAD_DELAY = 180; private final BlockingQueue<DagActionStore.LeaseParams> leaseParamsQueue = new LinkedBlockingQueue<>(); private final DagManagementStateStore dagManagementStateStore; private final DagProcessingEngineMetrics dagProcEngineMetrics; @Inject - public DagManagementTaskStreamImpl(Config config, Optional<DagActionStore> dagActionStore, - @Named(ConfigurationKeys.PROCESSING_LEASE_ARBITER_NAME) MultiActiveLeaseArbiter dagActionProcessingLeaseArbiter, Review Comment: whew... I had a suspicion, so glad I came back at the end to give it one more thought -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
