[
https://issues.apache.org/jira/browse/GOBBLIN-2136?focusedWorklogId=933458&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933458
]
ASF GitHub Bot logged work on GOBBLIN-2136:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/24 18:20
Start Date: 05/Sep/24 18:20
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4031:
URL: https://github.com/apache/gobblin/pull/4031#discussion_r1745977407
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/DagActionStoreChangeMonitor.java:
##########
@@ -407,20 +288,12 @@ protected static class LaunchSubmissionMetricProxy {
public LaunchSubmissionMetricProxy() {}
- public void markSuccess() {
- getSuccessMeter().mark();
- }
-
Review Comment:
we need to keep both of these `markSuccess` methods. It appears to be an
oversight that `DagManagementDagActionStoreChangeMonitor` is not marking the
success metric upon success, the way L370 is (above in
`submitFlowToDagManagerHelper`).
I believe it belongs here, just before the `break;`:
```
case REEVALUATE :
case RESUME:
dagManagement.addDagAction(new
DagActionStore.LeaseParams(dagAction));
break;
default:
```
Issue Time Tracking
-------------------
Worklog Id: (was: 933458)
Time Spent: 6h (was: 5h 50m)
> remove obsolete code related to DagManager
> ------------------------------------------
>
> Key: GOBBLIN-2136
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2136
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 6h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
