Will-Lo commented on code in PR #4070:
URL: https://github.com/apache/gobblin/pull/4070#discussion_r1823086220
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/trash/TimeBasedSnapshotCleanupPolicy.java:
##########
@@ -41,6 +42,7 @@ public TimeBasedSnapshotCleanupPolicy(Properties props) {
@Override
public boolean shouldDeleteSnapshot(FileStatus snapshot, Trash trash) {
DateTime snapshotTime =
Trash.TRASH_SNAPSHOT_NAME_FORMATTER.parseDateTime(snapshot.getPath().getName());
- return snapshotTime.plusMinutes(this.retentionMinutes).isBeforeNow();
+ // To ensure that the comparison between snapshotTime and the current time
is done in the same time zone
+ return
snapshotTime.plusMinutes(this.retentionMinutes).isBefore(DateTime.now(DateTimeZone.UTC));
Review Comment:
Should there be a configuration to ensure that it is using UTC compared to
the old behavior? You don't want existing retention jobs to have unintended
consequences due to change in behavior that is not explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
