[
https://issues.apache.org/jira/browse/GOBBLIN-2175?focusedWorklogId=947433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947433
]
ASF GitHub Bot logged work on GOBBLIN-2175:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/24 22:38
Start Date: 09/Dec/24 22:38
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4078:
URL: https://github.com/apache/gobblin/pull/4078#discussion_r1876633245
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/exception/FailedDatasetUrnsException.java:
##########
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.gobblin.temporal.exception;
+
+import java.io.IOException;
+
+/**
+ * An exception thrown when a set of dataset URNs fail to be processed.
+ */
+public class FailedDatasetUrnsException extends IOException {
+
+
+ /**
+ * Creates a new instance of this exception with the failed dataset URNs.
+ *
+ * @param failedDatasetUrns the String of failed dataset URNs joined by comma
+ */
+ public FailedDatasetUrnsException(String failedDatasetUrns) {
+ super("Failed to process the following dataset URNs: " +
failedDatasetUrns);
+ }
Review Comment:
rather than passing in a string with multiple URNs already joined, have the
ctor take a `List<String>` that keeps them separate. also add a member so
those catching the exception may access that list. continuing to format the
`super` call w/ the joined URNs as you currently are seems fine
Issue Time Tracking
-------------------
Worklog Id: (was: 947433)
Time Spent: 2h (was: 1h 50m)
> Fix partial commit in temporal flow
> -----------------------------------
>
> Key: GOBBLIN-2175
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2175
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
> Fix partial commit in temporal flow
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
