[
https://issues.apache.org/jira/browse/GOBBLIN-2175?focusedWorklogId=947434&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947434
]
ASF GitHub Bot logged work on GOBBLIN-2175:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/24 22:39
Start Date: 09/Dec/24 22:39
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4078:
URL: https://github.com/apache/gobblin/pull/4078#discussion_r1876806190
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/CommitStats.java:
##########
@@ -34,11 +36,13 @@
@Data
@NoArgsConstructor // IMPORTANT: for jackson (de)serialization
@RequiredArgsConstructor
+@Accessors(chain = true)
public class CommitStats {
@NonNull private Map<String, DatasetStats> datasetStats;
@NonNull private int numCommittedWorkUnits;
+ @NonNull private Optional<Exception> optFailure;
Review Comment:
let's treat these `@Data` POJOs as immutable and construct them
fully/finally initialized.
in fact, all these fields would have been `private final`, but that doesn't
play well w/ jackson's JSON deserialization, so they're forced to be `@NonNull
private` instead. let's continue w/ the original intent that they're immutable
`@Data` objects. (hence no `@Accessors`)
Issue Time Tracking
-------------------
Worklog Id: (was: 947434)
Time Spent: 2h 10m (was: 2h)
> Fix partial commit in temporal flow
> -----------------------------------
>
> Key: GOBBLIN-2175
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2175
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> Fix partial commit in temporal flow
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
