[
https://issues.apache.org/jira/browse/GOBBLIN-2189?focusedWorklogId=954260&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954260
]
ASF GitHub Bot logged work on GOBBLIN-2189:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Jan/25 12:19
Start Date: 26/Jan/25 12:19
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4092:
URL: https://github.com/apache/gobblin/pull/4092#discussion_r1929751150
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -637,103 +557,11 @@ private boolean shouldStickToTheSameNode(int
containerExitStatus) {
}
Review Comment:
Let's remove the unused private function `shouldStickToTheSameNode`
Issue Time Tracking
-------------------
Worklog Id: (was: 954260)
Time Spent: 1h 20m (was: 1h 10m)
> Implement ContainerCompletion callback in DynamicScalingYarnService
> -------------------------------------------------------------------
>
> Key: GOBBLIN-2189
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2189
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> DynamicScalingYarnService currently doesn't handle scaling down containers
> and neither does anything if container is killed abruptly or goes OOM. So to
> handle this scenario containerCompletion callback should be implemented to
> launch the replacement containers and also scaling down handling should be
> done.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
