[
https://issues.apache.org/jira/browse/GOBBLIN-2189?focusedWorklogId=955985&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955985
]
ASF GitHub Bot logged work on GOBBLIN-2189:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/25 05:21
Start Date: 07/Feb/25 05:21
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4092:
URL: https://github.com/apache/gobblin/pull/4092#discussion_r1945968829
##########
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/yarn/DynamicScalingYarnServiceManagerTest.java:
##########
@@ -69,14 +69,14 @@ public void testWhenScalingDirectivesIsNulOrEmpty() throws
IOException, Interrup
/** Note : this test uses {@link DummyScalingDirectiveSource}*/
@Test
public void testWithDummyScalingDirectiveSource() throws IOException,
InterruptedException {
- // DummyScalingDirectiveSource returns 2 scaling directives in first 3
invocations and after that it returns empty list
- // so the total number of invocations after three invocations should
always be 3
+ // DummyScalingDirectiveSource returns 2 scaling directives in first 5
invocations and after that it returns empty list
+ // so the total number of invocations after three invocations should
always be 5
TestDynamicScalingYarnServiceManager testDynamicScalingYarnServiceManager
= new TestDynamicScalingYarnServiceManager(
mockGobblinTemporalApplicationMaster, new
DummyScalingDirectiveSource());
testDynamicScalingYarnServiceManager.startUp();
- Thread.sleep(5000); // 5 seconds sleep so that
GetScalingDirectivesRunnable.run() is called for 5 times
+ Thread.sleep(7000); // 5 seconds sleep so that
GetScalingDirectivesRunnable.run() is called for 7 times
testDynamicScalingYarnServiceManager.shutDown();
- Mockito.verify(mockDynamicScalingYarnService,
Mockito.times(3)).reviseWorkforcePlanAndRequestNewContainers(Mockito.anyList());
+ Mockito.verify(mockDynamicScalingYarnService,
Mockito.times(5)).reviseWorkforcePlanAndRequestNewContainers(Mockito.anyList());
Review Comment:
In case of scaling directives returned by `ScalingDirectiveSource` impl
`reviseWorkforcePlanAndRequestNewContainers` is called that many times
here `DummyScalingDirectiveSource` returns scaling directives for 5 times so
5 invocations must happens to `reviseWorkforcePlanAndRequestNewContainers`
Issue Time Tracking
-------------------
Worklog Id: (was: 955985)
Time Spent: 2.5h (was: 2h 20m)
> Implement ContainerCompletion callback in DynamicScalingYarnService
> -------------------------------------------------------------------
>
> Key: GOBBLIN-2189
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2189
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> DynamicScalingYarnService currently doesn't handle scaling down containers
> and neither does anything if container is killed abruptly or goes OOM. So to
> handle this scenario containerCompletion callback should be implemented to
> launch the replacement containers and also scaling down handling should be
> done.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
