[
https://issues.apache.org/jira/browse/GOBBLIN-2191?focusedWorklogId=954473&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954473
]
ASF GitHub Bot logged work on GOBBLIN-2191:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/25 16:13
Start Date: 29/Jan/25 16:13
Worklog Time Spent: 10m
Work Description: abhishekmjain opened a new pull request, #4094:
URL: https://github.com/apache/gobblin/pull/4094
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN-2191) issues and references
them in the PR title. For example, "[GOBBLIN-2191] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2191
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Temporal Application Master is not shutting down due to a non-daemon thread
being alive. This thread is coming from the unclosed ExecutorService created in
GobblinJobLauncher.
The ExecutorService is now being closed leading to a graceful shutdown of
Temporal Application Master.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Verified in a test project which prints below log message in Application
Master container.
`ApplicationLauncher has already stopped` gets printed when the shutdown
hook gets called from
[ServiceBasedAppLauncher](https://github.com/apache/gobblin/blob/d58bbc0a12689e83696360f86235925743d1be3a/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/app/ServiceBasedAppLauncher.java#L167)
indicating a JVM shutdown.
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 954473)
Remaining Estimate: 0h
Time Spent: 10m
> Temporal AM application not stopping gracefully
> -----------------------------------------------
>
> Key: GOBBLIN-2191
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2191
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Temporal Application Master is not shutting down gracefully.
> It remains in running state even after all the processing is done due to an
> alive non-daemon thread.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
