[
https://issues.apache.org/jira/browse/GOBBLIN-2191?focusedWorklogId=954501&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-954501
]
ASF GitHub Bot logged work on GOBBLIN-2191:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/25 17:01
Start Date: 29/Jan/25 17:01
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4094:
URL: https://github.com/apache/gobblin/pull/4094#discussion_r1934264068
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -643,6 +643,12 @@ ApplicationId setupAndSubmitApplication() throws
IOException, YarnException, Int
LOGGER.info("Application Tracking URL: " +
applicationReport.getTrackingUrl());
LOGGER.info("Application User: " + applicationReport.getUser() + " Queue:
" + applicationReport.getQueue());
+ // Temporal workflow tracking url
+ String temporalWorkflowTrackingUrl = ConfigUtils.getString(config,
"gobblin.temporal.ui.server.url", "");
+ if (!temporalWorkflowTrackingUrl.isEmpty()) {
+ LOGGER.info("Temporal Workflow Tracking URL: " +
temporalWorkflowTrackingUrl);
Review Comment:
Replace this check with `StringUtils.isNotBlank(temporalWorkflowTrackingUrl)`
Issue Time Tracking
-------------------
Worklog Id: (was: 954501)
Time Spent: 20m (was: 10m)
> Temporal AM application not stopping gracefully
> -----------------------------------------------
>
> Key: GOBBLIN-2191
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2191
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Temporal Application Master is not shutting down gracefully.
> It remains in running state even after all the processing is done due to an
> alive non-daemon thread.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
