[
https://issues.apache.org/jira/browse/GOBBLIN-2190?focusedWorklogId=955095&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955095
]
ASF GitHub Bot logged work on GOBBLIN-2190:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/25 05:16
Start Date: 03/Feb/25 05:16
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4093:
URL: https://github.com/apache/gobblin/pull/4093#discussion_r1938792421
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/loadgen/workflow/impl/NestingExecOfIllustrationItemActivityWorkflowImpl.java:
##########
@@ -32,24 +34,11 @@
public class NestingExecOfIllustrationItemActivityWorkflowImpl
extends AbstractNestingExecWorkflowImpl<IllustrationItem, String> {
- // RetryOptions specify how to automatically handle retries when Activities
fail.
- private static final RetryOptions ACTIVITY_RETRY_OPTS =
RetryOptions.newBuilder()
- .setInitialInterval(Duration.ofSeconds(1))
- .setMaximumInterval(Duration.ofSeconds(100))
- .setBackoffCoefficient(2)
- .setMaximumAttempts(3)
- .build();
-
- private static final ActivityOptions ACTIVITY_OPTS =
ActivityOptions.newBuilder()
- .setStartToCloseTimeout(Duration.ofSeconds(10))
- .setRetryOptions(ACTIVITY_RETRY_OPTS)
- .build();
-
- private final IllustrationItemActivity activityStub =
- Workflow.newActivityStub(IllustrationItemActivity.class, ACTIVITY_OPTS);
-
@Override
- protected Promise<String> launchAsyncActivity(final IllustrationItem item) {
+ protected Promise<String> launchAsyncActivity(final IllustrationItem item,
final Properties props) {
+ final IllustrationItemActivity activityStub =
+ Workflow.newActivityStub(IllustrationItemActivity.class,
+
TemporalActivityUtils.buildActivityOptions(ActivityType.DEFAULT_ACTIVITY,
props));
Review Comment:
This class is not used in production but is useful for doing some poc /
testing purposes, so that's why used DEFAULT_ACTIVITY
Issue Time Tracking
-------------------
Worklog Id: (was: 955095)
Time Spent: 40m (was: 0.5h)
> Implement ActivityTimeoutStrategy for all Temporal Activities
> -------------------------------------------------------------
>
> Key: GOBBLIN-2190
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2190
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently TImeouts of all Temporal Activity are hardcoded and cant change
> during runtime, change those to make them configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
