[
https://issues.apache.org/jira/browse/GOBBLIN-2190?focusedWorklogId=955096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955096
]
ASF GitHub Bot logged work on GOBBLIN-2190:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/25 05:36
Start Date: 03/Feb/25 05:36
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4093:
URL: https://github.com/apache/gobblin/pull/4093#discussion_r1938804081
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/workflow/impl/CommitStepWorkflowImpl.java:
##########
@@ -42,22 +42,10 @@
@Slf4j
public class CommitStepWorkflowImpl implements CommitStepWorkflow {
- private static final RetryOptions ACTIVITY_RETRY_OPTS =
RetryOptions.newBuilder()
- .setInitialInterval(Duration.ofSeconds(3))
- .setMaximumInterval(Duration.ofSeconds(100))
- .setBackoffCoefficient(2)
- .setMaximumAttempts(4)
- .build();
-
- private static final ActivityOptions ACTIVITY_OPTS =
ActivityOptions.newBuilder()
- .setStartToCloseTimeout(Duration.ofHours(3)) // TODO: make
configurable... also add activity heartbeats
- .setRetryOptions(ACTIVITY_RETRY_OPTS)
- .build();
-
- private final CommitActivity activityStub =
Workflow.newActivityStub(CommitActivity.class, ACTIVITY_OPTS);
-
@Override
- public CommitStats commit(WUProcessingSpec workSpec) {
+ public CommitStats commit(WUProcessingSpec workSpec, final Properties props)
{
+ final CommitActivity activityStub =
Workflow.newActivityStub(CommitActivity.class,
TemporalActivityUtils.buildActivityOptions(
Review Comment:
Currently there is only one place it is used so we can see later if it is
required or not.
Issue Time Tracking
-------------------
Worklog Id: (was: 955096)
Time Spent: 50m (was: 40m)
> Implement ActivityTimeoutStrategy for all Temporal Activities
> -------------------------------------------------------------
>
> Key: GOBBLIN-2190
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2190
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Currently TImeouts of all Temporal Activity are hardcoded and cant change
> during runtime, change those to make them configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
