[
https://issues.apache.org/jira/browse/GOBBLIN-2193?focusedWorklogId=955873&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955873
]
ASF GitHub Bot logged work on GOBBLIN-2193:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Feb/25 14:54
Start Date: 06/Feb/25 14:54
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4096:
URL: https://github.com/apache/gobblin/pull/4096#discussion_r1944863514
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java:
##########
@@ -36,6 +36,9 @@
import io.temporal.serviceclient.WorkflowServiceStubs;
import io.temporal.workflow.Workflow;
+import org.apache.commons.text.TextStringBuilder;
+import org.apache.gobblin.cluster.event.JobSummaryEvent;
+import org.apache.gobblin.runtime.JobState;
Review Comment:
Might have missed in first review please update the import order as
`Import order: java, org, com, gobblin.`
https://gobblin.apache.org/docs/developer-guide/CodingStyle/
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -37,6 +37,8 @@
import java.util.stream.IntStream;
import org.apache.commons.lang.StringUtils;
+import org.apache.gobblin.cluster.event.JobSummaryEvent;
+import org.apache.gobblin.runtime.JobState;
Review Comment:
similar here as well
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -380,6 +382,19 @@ public void launch() throws IOException, YarnException,
InterruptedException {
}, 0, this.appReportIntervalMinutes, TimeUnit.MINUTES);
addServices();
+
+ synchronized (this.applicationDone) {
+ while (!this.applicationCompleted) {
+ try {
+ this.applicationDone.wait();
+ if (this.applicationFailed) {
+ throw new RuntimeException("Gobblin Yarn application failed");
+ }
+ } catch (InterruptedException ie) {
+ LOGGER.error("Interrupted while waiting for the Gobblin Yarn
application to finish", ie);
+ }
+ }
+ }
Review Comment:
QQ - Can the throwing of RuntimeException affects the shutdown in anyway ?
##########
gobblin-temporal/src/test/java/org/apache/gobblin/temporal/yarn/YarnServiceTest.java:
##########
@@ -20,6 +20,8 @@
import java.io.IOException;
import java.net.URL;
+import org.apache.gobblin.cluster.event.JobSummaryEvent;
+import org.apache.gobblin.runtime.JobState;
Review Comment:
here also
Issue Time Tracking
-------------------
Worklog Id: (was: 955873)
Time Spent: 1h 20m (was: 1h 10m)
> Fail Azkaban job on when temporal job fails
> -------------------------------------------
>
> Key: GOBBLIN-2193
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2193
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Swapnil Palash
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Currently when the temporal job running on Yarn fails, we don't propagate the
> error back to Azkaban job which launches the Yarn Application.
> The change here bubbles the issues encountered when the job fails upto the
> GobblinYarnAppLaucher run by the Azkaban job and fails with a
> RuntimeException after logging the issues summary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
