[
https://issues.apache.org/jira/browse/GOBBLIN-2193?focusedWorklogId=957256&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957256
]
ASF GitHub Bot logged work on GOBBLIN-2193:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Feb/25 13:44
Start Date: 16/Feb/25 13:44
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4096:
URL: https://github.com/apache/gobblin/pull/4096#discussion_r1957330235
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -482,9 +499,17 @@ public void
handleApplicationReportArrivalEvent(ApplicationReportArrivalEvent ap
LOGGER.info("Gobblin Yarn application finished with final status: " +
applicationReport.getFinalApplicationStatus().toString());
if (applicationReport.getFinalApplicationStatus() ==
FinalApplicationStatus.FAILED) {
- LOGGER.error("Gobblin Yarn application failed for the following
reason: " + applicationReport.getDiagnostics());
+ applicationFailed = true;
+ LOGGER.error("Gobblin Yarn application failed because of the following
issues: " + applicationReport.getDiagnostics());
+ } else if (StringUtils.isNotBlank(applicationReport.getDiagnostics())) {
Review Comment:
It will be useful in case where no work units were generated as in that
cases job always succeeds so it will be easier to know directly.
Issue Time Tracking
-------------------
Worklog Id: (was: 957256)
Time Spent: 2h 20m (was: 2h 10m)
> Fail Azkaban job on when temporal job fails
> -------------------------------------------
>
> Key: GOBBLIN-2193
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2193
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Swapnil Palash
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently when the temporal job running on Yarn fails, we don't propagate the
> error back to Azkaban job which launches the Yarn Application.
> The change here bubbles the issues encountered when the job fails upto the
> GobblinYarnAppLaucher run by the Azkaban job and fails with a
> RuntimeException after logging the issues summary.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
