[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=957109&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957109
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/25 11:48
Start Date: 14/Feb/25 11:48
Worklog Time Spent: 10m
Work Description: iPalash commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1956016257
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobLauncher.java:
##########
@@ -188,4 +191,17 @@ protected void removeTasksFromCurrentJob(List<String>
workUnitIdsToRemove) {
protected void addTasksToCurrentJob(List<WorkUnit> workUnitsToAdd) {
log.warn("NOT IMPLEMENTED: Temporal addTasksToCurrentJob");
}
+
+ @Override
+ public void close() throws IOException {
+ try {
+ // Calling cancel before calling close on serviceStubs as it will
shutdown the service which is required during cancellation.
+ cancelJob(jobListener);
+ } catch (Exception e) {
+ log.error("Exception occurred while cancelling job", e);
+ } finally {
+ managedWorkflowServiceStubs.close();
Review Comment:
can this throw an exception? If so, close doesn't get called.
looping twice with try/finally might be the correct way to do this.
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/service/ManagedWorkflowServiceStubs.java:
##########
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.workflows.service;
+
+import java.io.Closeable;
+
+import io.temporal.serviceclient.WorkflowServiceStubs;
+import lombok.Getter;
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * A wrapper class of {@link WorkflowServiceStubs} that implements the
Closeable interface.
+ * It manages the lifecycle of {@link WorkflowServiceStubs}, ensuring proper
shutdown and resource cleanup.
+ */
+@Getter
+@Slf4j
+public class ManagedWorkflowServiceStubs implements Closeable {
+ private final WorkflowServiceStubs workflowServiceStubs;
+
+ public ManagedWorkflowServiceStubs(WorkflowServiceStubs serviceStubs) {
+ this.workflowServiceStubs = serviceStubs;
+ }
+
+ @Override
+ public void close() {
+ try {
+ workflowServiceStubs.getOptions().getMetricsScope().close();
Review Comment:
What happens if there is no metrics scope present?
either looping twice with try/finally or checking what presence of the scope
is needed.
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -137,13 +137,9 @@ public GobblinJobLauncher(Properties jobProps, Path
appWorkDir,
@Override
public void close() throws IOException {
try {
- executeCancellation();
Review Comment:
This change impacts many child classes
<img width="264" alt="image"
src="https://github.com/user-attachments/assets/b4667e30-5cd0-4a51-9e90-b3c55fdd3f83";
/>
Even though none of them implement the executeCancellation method but this
is still a divergence which should be documented IMO
Issue Time Tracking
-------------------
Worklog Id: (was: 957109)
Time Spent: 2.5h (was: 2h 20m)
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
