[
https://issues.apache.org/jira/browse/GOBBLIN-2194?focusedWorklogId=957076&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957076
]
ASF GitHub Bot logged work on GOBBLIN-2194:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/25 09:34
Start Date: 14/Feb/25 09:34
Worklog Time Spent: 10m
Work Description: iPalash commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1955824192
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinTemporalJobScheduler.java:
##########
@@ -218,7 +218,11 @@ public void
handleNewJobConfigArrival(NewJobConfigArrivalEvent newJobArrival) {
throw new RuntimeException(e);
}
}));
- launcher.launchJob(listener);
+ try {
+ launcher.launchJob(listener);
+ } finally {
+ launcher.close();
Review Comment:
Is there value in adding it to the shutdown hook above as well? or putting
it another way should we add the close functionally added to
`GobblinTemporalJobLauncher.close` to `executeCancellation` instead triggered
via cancelJob. That way we don't need to add the close override there.
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java:
##########
@@ -292,6 +293,12 @@ public synchronized void stop() {
this.containerMetrics.get().stopMetricsReporting();
}
+ try {
+ this.workflowServiceStubs.getOptions().getMetricsScope().close();
Review Comment:
Should closing the `this.workflowServiceStubs` handle the metric Scope
closure instead of this class doing it here?
Why does that not happen implicitly?
Issue Time Tracking
-------------------
Worklog Id: (was: 957076)
Time Spent: 1h 10m (was: 1h)
> Fix Temporal metrics scope closure bug
> --------------------------------------
>
> Key: GOBBLIN-2194
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2194
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> As part of https://issues.apache.org/jira/browse/GOBBLIN-2192 a bug was
> introduced where the metrics scope object was not closed resulting in AM
> container not shutting down.
> Metrics scope should be closed wherever initialized.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
