[
https://issues.apache.org/jira/browse/GOBBLIN-2190?focusedWorklogId=957830&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957830
]
ASF GitHub Bot logged work on GOBBLIN-2190:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/25 02:32
Start Date: 20/Feb/25 02:32
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4093:
URL: https://github.com/apache/gobblin/pull/4093#discussion_r1962770103
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/ActivityConfigurationStrategy.java:
##########
@@ -0,0 +1,117 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.temporal.ddm.activity;
+
+import java.time.Duration;
+import java.util.Properties;
+
+import org.apache.gobblin.temporal.GobblinTemporalConfigurationKeys;
+import org.apache.gobblin.util.PropertiesUtils;
+
+
+/**
+ * Interface for defining activity configuration strategies for different
Temporal activities.
+ * Each strategy provides a method to retrieve configuration details, such as
timeout duration, based on the provided properties.
+ */
+public interface ActivityConfigurationStrategy {
+ /** Default start to close timeout duration for any activity if not
specified. */
+ Duration defaultStartToCloseTimeout = Duration.ofMinutes(180);
+ int DEFAULT_GENERATE_WORKUNITS_ACTIVITY_STARTTOCLOSE_TIMEOUT_MINUTES = 120;
Review Comment:
Used 360 as default timeout for all activity
Issue Time Tracking
-------------------
Worklog Id: (was: 957830)
Time Spent: 2h 20m (was: 2h 10m)
> Implement ActivityTimeoutStrategy for all Temporal Activities
> -------------------------------------------------------------
>
> Key: GOBBLIN-2190
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2190
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently TImeouts of all Temporal Activity are hardcoded and cant change
> during runtime, change those to make them configurable.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
