[
https://issues.apache.org/jira/browse/GOBBLIN-2208?focusedWorklogId=970121&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-970121
]
ASF GitHub Bot logged work on GOBBLIN-2208:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/25 07:11
Start Date: 21/May/25 07:11
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4117:
URL: https://github.com/apache/gobblin/pull/4117#discussion_r2099535608
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/HadoopUtils.java:
##########
@@ -783,14 +816,21 @@ public static void ensureDirectoryExists(FileSystem fs,
Path path, Iterator<Owne
OwnerAndPermission ownerAndPermission =
ownerAndPermissionIterator.next();
if (path.getParent() != null) {
- ensureDirectoryExists(fs, path.getParent(),
ownerAndPermissionIterator, failIfOwnerSetFails);
+ ensureDirectoryExists(fs, path.getParent(),
ownerAndPermissionIterator, failIfOwnerSetFails, copyOnlySourceAclToDest);
}
if (!fs.mkdirs(path)) {
// fs.mkdirs returns false if path already existed. Do not overwrite
permissions
return;
}
-
+ try {
+ if (copyOnlySourceAclToDest) {
+ fs.removeAcl(path);
Review Comment:
`removeAcl` still preserves some permissions, see
[here](https://hadoop.apache.org/docs/stable/api/org/apache/hadoop/fs/FileSystem.html#removeAcl-org.apache.hadoop.fs.Path-).
should we also use `removeDefaultAcl` ?
Issue Time Tracking
-------------------
Worklog Id: (was: 970121)
Time Spent: 20m (was: 10m)
> ACL Mismatch between source and dest for Manifest based copy
> ------------------------------------------------------------
>
> Key: GOBBLIN-2208
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2208
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vaibhav Singhal
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> During manifest based copy due to default ACL inheritence in the destination,
> after manifest based copy source and destination end up having different
> ACL's for source and destination
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
