[
https://issues.apache.org/jira/browse/GOBBLIN-2208?focusedWorklogId=970124&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-970124
]
ASF GitHub Bot logged work on GOBBLIN-2208:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/May/25 07:21
Start Date: 21/May/25 07:21
Worklog Time Spent: 10m
Work Description: vsinghal85 commented on code in PR #4117:
URL: https://github.com/apache/gobblin/pull/4117#discussion_r2099552892
##########
gobblin-utility/src/main/java/org/apache/gobblin/util/HadoopUtils.java:
##########
@@ -783,14 +816,21 @@ public static void ensureDirectoryExists(FileSystem fs,
Path path, Iterator<Owne
OwnerAndPermission ownerAndPermission =
ownerAndPermissionIterator.next();
if (path.getParent() != null) {
- ensureDirectoryExists(fs, path.getParent(),
ownerAndPermissionIterator, failIfOwnerSetFails);
+ ensureDirectoryExists(fs, path.getParent(),
ownerAndPermissionIterator, failIfOwnerSetFails, copyOnlySourceAclToDest);
}
if (!fs.mkdirs(path)) {
// fs.mkdirs returns false if path already existed. Do not overwrite
permissions
return;
}
-
+ try {
+ if (copyOnlySourceAclToDest) {
+ fs.removeAcl(path);
Review Comment:
removeDefaultAcl only removes default ACL's, in ACL inheritance default
ACL's are inherited as well as default ACL's are inherited as direct ACL's they
also need to be removed, so removeAcl removes all ACL's, while removeDefaultAcl
only removes default one's so that would leave some extra ACL's.
Anyway other permissions later on in the code are being overwritten so we
need not worry about them.
Issue Time Tracking
-------------------
Worklog Id: (was: 970124)
Time Spent: 50m (was: 40m)
> ACL Mismatch between source and dest for Manifest based copy
> ------------------------------------------------------------
>
> Key: GOBBLIN-2208
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2208
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vaibhav Singhal
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> During manifest based copy due to default ACL inheritence in the destination,
> after manifest based copy source and destination end up having different
> ACL's for source and destination
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
