[ 
https://issues.apache.org/jira/browse/GOBBLIN-2211?focusedWorklogId=975728&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-975728
 ]

ASF GitHub Bot logged work on GOBBLIN-2211:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Jul/25 17:39
            Start Date: 22/Jul/25 17:39
    Worklog Time Spent: 10m 
      Work Description: abhishekmjain commented on code in PR #4121:
URL: https://github.com/apache/gobblin/pull/4121#discussion_r2223342807


##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -234,8 +248,31 @@ protected void 
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
           boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
 
           if (updatedJobStatus.getRight() == NewState.FINISHED && 
!retryRequired) {
-            // do not send event if retry is required, because it can alert 
users to re-submit a job that is already set to be retried by GaaS
-            this.eventProducer.emitObservabilityEvent(jobStatus);
+            if (isErrorClassificationEnabled) {
+              long startTime = System.currentTimeMillis();

Review Comment:
   can we start the try block after startTime instead of after the first log 
line?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 975728)
    Time Spent: 4h  (was: 3h 50m)

> Implement Error Classification based on execution issues
> --------------------------------------------------------
>
>                 Key: GOBBLIN-2211
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2211
>             Project: Apache Gobblin
>          Issue Type: Bug
>          Components: gobblin-service
>            Reporter: Abhishek Jain
>            Assignee: Abhishek Tiwari
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h
>
> Implement Error Classification to categorize the failure reason based on 
> issues encountered.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to