[
https://issues.apache.org/jira/browse/GOBBLIN-2211?focusedWorklogId=975921&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-975921
]
ASF GitHub Bot logged work on GOBBLIN-2211:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Jul/25 17:36
Start Date: 23/Jul/25 17:36
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4121:
URL: https://github.com/apache/gobblin/pull/4121#discussion_r2226155208
##########
gobblin-metastore/src/main/java/org/apache/gobblin/metastore/MysqlErrorPatternStore.java:
##########
@@ -279,64 +302,46 @@ public List<ErrorPatternProfile>
getErrorPatternsByCategory(String categoryName)
}
@Override
- public Category getDefaultCategory()
+ public ErrorCategory getDefaultCategory()
throws IOException {
- if (hasIsDefaultColumn()) {
- Category cat = getDefaultCategoryFromIsDefault();
+ // 1. Try to use the configured default category name if set
+ if (configuredDefaultCategoryName != null &&
!configuredDefaultCategoryName.trim().isEmpty()) {
Review Comment:
My bad, it was `Strings.isNullOrEmpty()`. `StringUtils.isBlank()` is
actually better, we don't need `isEmpty()` right? `isBlank()` would also check
for `isEmpty()`.
Issue Time Tracking
-------------------
Worklog Id: (was: 975921)
Time Spent: 5h 20m (was: 5h 10m)
> Implement Error Classification based on execution issues
> --------------------------------------------------------
>
> Key: GOBBLIN-2211
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2211
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Implement Error Classification to categorize the failure reason based on
> issues encountered.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
