[
https://issues.apache.org/jira/browse/GOBBLIN-2204?focusedWorklogId=977603&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-977603
]
ASF GitHub Bot logged work on GOBBLIN-2204:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Aug/25 05:02
Start Date: 05/Aug/25 05:02
Worklog Time Spent: 10m
Work Description: khandelwal-prateek commented on code in PR #4113:
URL: https://github.com/apache/gobblin/pull/4113#discussion_r2253112881
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/local/LocalTaskStateTracker.java:
##########
@@ -89,8 +90,11 @@ public void onTaskRunCompletion(Task task) {
try {
// Check the task state and handle task retry if task failed and
// it has not reached the maximum number of retries
+
WorkUnitState.WorkingState state = task.getTaskState().getWorkingState();
- if (state == WorkUnitState.WorkingState.FAILED && task.getRetryCount() <
this.maxTaskRetries) {
+ boolean dataQualityEnabled =
jobState.getPropAsBoolean(ConfigurationKeys.DATA_QUALITY_ENABLED_KEY,
ConfigurationKeys.DEFAULT_DATA_QUALITY_ENABLED);
+ String dataQualityResult =
task.getTaskState().getProp(ConfigurationKeys.TASK_LEVEL_POLICY_RESULT_KEY);
+ if (((dataQualityEnabled &&
DataQualityStatus.FAILED.name().equals(dataQualityResult)) || state ==
WorkUnitState.WorkingState.FAILED) && task.getRetryCount() <
this.maxTaskRetries) {
Review Comment:
if `dataQualityEnabled = true` && dataQualityResult is `FAILED`, then task
state would always be `FAILED`.. we don't need to check for DQ result
explicitly for retrying
Issue Time Tracking
-------------------
Worklog Id: (was: 977603)
Time Spent: 2h 40m (was: 2.5h)
> FileSize Data Quality implementation for FileBasedCopy
> ------------------------------------------------------
>
> Key: GOBBLIN-2204
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2204
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vaibhav Singhal
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
