abhishekmjain commented on code in PR #4129:
URL: https://github.com/apache/gobblin/pull/4129#discussion_r2269489029
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -79,7 +79,12 @@ public final void process(DagManagementStateStore
dagManagementStateStore,
throw e;
}
logContextualizedInfo("ready to process");
+ try {
act(dagManagementStateStore, state, dagProcEngineMetrics);
+ } catch (Exception e) {
+ dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
+ throw e;
+ }
Review Comment:
In `act` we mark dag actions as succeeded which can also throw exceptions.
Such exceptions will mark the dag actions as failed with this change, which may
not be ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
