thisisArjit commented on code in PR #4129:
URL: https://github.com/apache/gobblin/pull/4129#discussion_r2272897692
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -79,7 +79,12 @@ public final void process(DagManagementStateStore
dagManagementStateStore,
throw e;
}
logContextualizedInfo("ready to process");
+ try {
act(dagManagementStateStore, state, dagProcEngineMetrics);
+ } catch (Exception e) {
+ dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
+ throw e;
+ }
Review Comment:
In case act is successful, the only method where it can throw exception is:
dagProcEngineMetrics.markDagActionsAct(getDagActionType(), true); which we are
calling after catching exception. In that case, it will again throw exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
