[
https://issues.apache.org/jira/browse/GOBBLIN-2218?focusedWorklogId=978691&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-978691
]
ASF GitHub Bot logged work on GOBBLIN-2218:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/25 09:26
Start Date: 13/Aug/25 09:26
Worklog Time Spent: 10m
Work Description: abhishekmjain commented on code in PR #4130:
URL: https://github.com/apache/gobblin/pull/4130#discussion_r2272690150
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -698,8 +698,13 @@ public void executeImpl(JobExecutionContext context)
throws JobExecutionExceptio
} else {
jobProps.setProperty(ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY,
String.valueOf(triggerTimeMillis));
- _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: {} - Job triggered by "
- + "scheduler", triggerTimeMillis,
utcDateAsUTCEpochMillis(trigger.getNextFireTime()));
+ if(trigger.getNextFireTime() == null){
+ _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: NA - Job triggered by "
+ + "scheduler", triggerTimeMillis);
+ } else {
+ _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: {} - Job triggered by "
+ + "scheduler", triggerTimeMillis,
utcDateAsUTCEpochMillis(trigger.getNextFireTime()));
+ }
Review Comment:
nit: can you install gobblin codestyle and format the newly added code?
Issue Time Tracking
-------------------
Worklog Id: (was: 978691)
Time Spent: 20m (was: 10m)
> Handle single schedule jobs failures
> ------------------------------------
>
> Key: GOBBLIN-2218
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2218
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vaibhav Singhal
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
