[
https://issues.apache.org/jira/browse/GOBBLIN-2217?focusedWorklogId=978706&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-978706
]
ASF GitHub Bot logged work on GOBBLIN-2217:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Aug/25 10:35
Start Date: 13/Aug/25 10:35
Worklog Time Spent: 10m
Work Description: thisisArjit commented on code in PR #4129:
URL: https://github.com/apache/gobblin/pull/4129#discussion_r2272897692
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/DagProc.java:
##########
@@ -79,7 +79,12 @@ public final void process(DagManagementStateStore
dagManagementStateStore,
throw e;
}
logContextualizedInfo("ready to process");
+ try {
act(dagManagementStateStore, state, dagProcEngineMetrics);
+ } catch (Exception e) {
+ dagProcEngineMetrics.markDagActionsAct(getDagActionType(), false);
+ throw e;
+ }
Review Comment:
In case act is successful, the only method where it can throw exception is:
dagProcEngineMetrics.markDagActionsAct(getDagActionType(), true); which we are
calling after catching exception. In that case, it will again throw exception.
Issue Time Tracking
-------------------
Worklog Id: (was: 978706)
Remaining Estimate: 0h
Time Spent: 10m
> Emit dag action failed metric
> -----------------------------
>
> Key: GOBBLIN-2217
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2217
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Abhishek Jain
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
