pratapaditya04 commented on code in PR #4167:
URL: https://github.com/apache/gobblin/pull/4167#discussion_r2915813124
##########
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowExecutionResource.java:
##########
@@ -167,6 +169,11 @@ public static FlowExecution convertFlowStatus(FlowStatus
monitoringFlowStatus,
if (queriedJobStatus.getMessage() != null) {
flowMessage = queriedJobStatus.getMessage();
}
+ if (includeIssues) {
Review Comment:
getIssues() returns an Optional — if it's empty this will throw
NoSuchElementException. Should be:
```
queriedJobStatus.getIssues().ifPresent(issues ->
flowIssues.addAll(issues.stream()
.map(FlowExecutionResource::convertIssueToRestApiObject)
.collect(Collectors.toList())));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
