agam-99 commented on code in PR #4167:
URL: https://github.com/apache/gobblin/pull/4167#discussion_r2916243032
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
@@ -86,10 +91,13 @@ protected void act(DagManagementStateStore
dagManagementStateStore, Pair<Optiona
if (!isRetry &&
!FlowStatusGenerator.FINISHED_STATUSES.contains(executionStatus.name())) {
// this may happen if adding job status in the store failed/delayed
after adding a ReevaluateDagAction in KafkaJobStatusMonitor
- throw new RuntimeException(String.format("Job status for dagNode %s is
%s. Re-evaluate dag action should have been "
+ String message = String.format("Job status for dagNode %s is %s.
Re-evaluate dag action should have been "
Review Comment:
it's used by both emitJobIssue and throw new RuntimeException(message), so
extracted it
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/ReevaluateDagProc.java:
##########
Review Comment:
makes sense, added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
