agam-99 opened a new pull request, #4178: URL: https://github.com/apache/gobblin/pull/4178
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
When the Gobblin YARN ApplicationMaster fails to start due to a bootstrap
failure
(e.g. token refresh failure, HDFS quota exceeded, missing credentials),
the Gobblin
job runtime never launches and no Kafka tracking events are emitted. As a
result,
GaaS sees the job stuck in `ORCHESTRATED` state indefinitely with no
`issues[]`
populated and no way for the user to diagnose the failure.
**Fix:** `AzkabanGobblinYarnAppLauncher` now initialises a
`ServiceBasedAppLauncher`
before calling `launch()`, following the same pattern as
`IvyJobLauncherTemporal`.
On `launch()` failure it emits:
- A `JOB_FAILED` timing event — transitions the GaaS job status to `FAILED`
- An `IssueEventBuilder` — populates the `issues[]` array with the
root-cause
exception summary and stack trace
The `ServiceBasedAppLauncher` correctly resolves the Xinfra SSL keystore
path by
running `XinfraDynamicConfigGenerator`, which reads the certificate from
the Hadoop
token file (`HADOOP_TOKEN_FILE_LOCATION`) and writes it to a temp file —
fixing the
`./var/identity.p12 (No such file or directory)` error in GGW pods. The
`applicationLauncher.stop()` in the `finally` block flushes all events to
Kafka via
Xinfra before the process exits.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added `AzkabanGobblinYarnAppLauncherTest` with three tests:
- `runCallsSubmitJobFailedEventOnLaunchFailure` — verifies `JOB_FAILED`
timing event
and `IssueEventBuilder` are emitted when `launch()` throws, and
exception propagates
- `runDoesNotCallSubmitJobFailedEventOnSuccess` — verifies no events
emitted on success
- `issueEventContainsFlowMetadata` — verifies `IssueEventBuilder` carries
correct
`flowGroup`, `flowName`, `flowExecutionId`, and `jobName` metadata
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
