pratapaditya04 commented on code in PR #4178:
URL: https://github.com/apache/gobblin/pull/4178#discussion_r3009328827
##########
gobblin-modules/gobblin-azkaban/src/main/java/org/apache/gobblin/azkaban/AzkabanGobblinYarnAppLauncher.java:
##########
@@ -56,29 +79,89 @@
public class AzkabanGobblinYarnAppLauncher extends AbstractJob {
private static final Logger LOGGER =
Logger.getLogger(AzkabanGobblinYarnAppLauncher.class);
+ /** Config prefix for the {@link ServiceBasedAppLauncher} used for
bootstrap-failure event reporting. */
+ private static final String APP_LAUNCHER_PREFIX = "gobblinYarnAppLauncher";
+
private final GobblinYarnAppLauncher gobblinYarnAppLauncher;
+ private final Properties gobblinProps;
+ private final ApplicationLauncher applicationLauncher;
+ private final EventSubmitter eventSubmitter;
@Getter
protected final YarnConfiguration yarnConfiguration;
- public AzkabanGobblinYarnAppLauncher(String jobId, Properties gobblinProps)
- throws IOException {
+ public AzkabanGobblinYarnAppLauncher(String jobId, Properties gobblinProps)
throws Exception {
super(jobId, LOGGER);
gobblinProps =
AzkabanLauncherUtils.undoPlaceholderConversion(gobblinProps);
addRuntimeProperties(gobblinProps);
+ this.gobblinProps = gobblinProps;
- Config gobblinConfig = ConfigUtils.propertiesToConfig(gobblinProps);
+ // Populate correct SSL keystore path from the Hadoop token file so Xinfra
reporters work in
+ // the GGW pod (XinfraDynamicConfigGenerator writes the cert to a temp
file and sets the path)
Review Comment:
Dont think we have XinfraDynamicConfigGenerator/GGW reference in OSS Gobblin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
