agam-99 opened a new pull request, #4181: URL: https://github.com/apache/gobblin/pull/4181
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-XXXX
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
`RecursiveCopyableDataset.getCopyableFilesImpl` iterates over
`filesInSource` entries and calls
`CopyableFile.resolveReplicatedOwnerAndPermissionsRecursively(fs,
file.getPath().getParent(), replacedPrefix, ...)`
for each. This method requires `replacedPrefix` to be an ancestor of
`file.getPath().getParent()`.
When `source.path` points to an **empty directory**,
`FileListUtils.listFilesToCopyAtPath`
(with `includeEmptyDirectories=true`) returns the directory itself as the
sole `FileStatus` entry.
For this entry `file.getPath() == replacedPrefix`, so
`file.getPath().getParent()` is one level
*above* `replacedPrefix`. This inverts the ancestry check and throws:
IOException: toPath /source must be an ancestor of fromPath /
**Fix:** Skip `FileStatus` entries where `isDirectory=true` before
attempting permission resolution.
Empty source directories produce no copy work units by design — directory
creation at the destination
is handled implicitly when files are published into them. A `WARN`-level
log is emitted so operators
can diagnose misconfigured source paths.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Added two tests to `RecursiveCopyableDatasetTest`:
- `testEmptySourceDirectoryProducesNoCopyEntities` — verifies that when
`filesInSource` contains only
the empty-directory entry (the exact condition that triggered the bug),
`getCopyableFiles` returns
zero copy entities rather than throwing `IOException`
- `testMixedSourceWithDirectoryEntrySkipsDirectories` — verifies that when
a directory entry is mixed
in with real files, the real files are copied and the directory entry is
silently skipped
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits
if they address the same issue. In addition, my commits follow the
guidelines from
"[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
