DaisyModi commented on code in PR #4191:
URL: https://github.com/apache/gobblin/pull/4191#discussion_r3232398099
##########
gobblin-metrics-libs/gobblin-metrics-base/src/main/avro/DagActionStoreChangeEvent.avsc:
##########
@@ -50,6 +50,11 @@
},
"doc" : "type of dag action",
"compliance" : "NONE"
- }
- ]
+ }, {
+ "name" : "dbUpdateTimeMillis",
Review Comment:
Why not name the avro field storeInsertTimeMillis as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
