DaisyModi commented on code in PR #4191:
URL: https://github.com/apache/gobblin/pull/4191#discussion_r3232410438
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagActionStore.java:
##########
@@ -100,19 +100,37 @@ public Dag.DagId getDagId() {
* {@link DagAction} along with the time it was requested, denoted by the
`eventTimeMillis` field. It also tracks
* whether it has been previously passed to the {@link
MultiActiveLeaseArbiter} to attempt ownership over the flow
* event, indicated by the 'isReminder' field (true when it has been
previously attempted).
+ *
+ * The `storeInsertTimeMillis` field carries the original DagAction store
row-insert time (sourced upstream
+ * from the CDC binlog event timestamp) when known. It is independent of
`eventTimeMillis`, which the lease
+ * arbiter may rewrite via consensus. A value of {@link
#UNKNOWN_STORE_INSERT_TIME_MILLIS} signals "not provided"
+ * and is the default for callers that do not have access to the source
timestamp.
*/
+ long UNKNOWN_STORE_INSERT_TIME_MILLIS = -1L;
Review Comment:
Nit: Can be moved to LeaseParams
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
