[
https://issues.apache.org/jira/browse/GOBBLIN-693?focusedWorklogId=206556&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206556
]
ASF GitHub Bot logged work on GOBBLIN-693:
------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Mar/19 17:53
Start Date: 01/Mar/19 17:53
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2565: [GOBBLIN-693]
Add ORC hive serde manager
URL: https://github.com/apache/incubator-gobblin/pull/2565#discussion_r261696977
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveSerDeManager.java
##########
@@ -79,7 +80,8 @@ protected HiveSerDeManager(State props) {
public abstract boolean haveSameSchema(HiveRegistrationUnit unit1,
HiveRegistrationUnit unit2) throws IOException;
public enum Implementation {
- AVRO(HiveAvroSerDeManager.class.getName());
+ AVRO(HiveAvroSerDeManager.class.getName()),
Review comment:
Should we use service providers instead of a hard-coded list of
implementations? This prevents third parties from adding their own
implementations.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 206556)
Time Spent: 0.5h (was: 20m)
> Add ORC hive serde manager
> --------------------------
>
> Key: GOBBLIN-693
> URL: https://issues.apache.org/jira/browse/GOBBLIN-693
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Hung Tran
> Assignee: Hung Tran
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Add an ORC hive serde manager to register ORC datasets in Hive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
