[ 
https://issues.apache.org/jira/browse/GOBBLIN-693?focusedWorklogId=206611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206611
 ]

ASF GitHub Bot logged work on GOBBLIN-693:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/19 19:38
            Start Date: 01/Mar/19 19:38
    Worklog Time Spent: 10m 
      Work Description: htran1 commented on pull request #2565: [GOBBLIN-693] 
Add ORC hive serde manager
URL: https://github.com/apache/incubator-gobblin/pull/2565#discussion_r261732673
 
 

 ##########
 File path: 
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/HiveSerDeManager.java
 ##########
 @@ -79,7 +80,8 @@ protected HiveSerDeManager(State props) {
   public abstract boolean haveSameSchema(HiveRegistrationUnit unit1, 
HiveRegistrationUnit unit2) throws IOException;
 
   public enum Implementation {
-    AVRO(HiveAvroSerDeManager.class.getName());
+    AVRO(HiveAvroSerDeManager.class.getName()),
 
 Review comment:
   Existing code has a fallback to treating the implementation name as a class 
name and instantiating the class using the name. The implementation names here 
are aliases to the class name.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 206611)
    Time Spent: 40m  (was: 0.5h)

> Add ORC hive serde manager
> --------------------------
>
>                 Key: GOBBLIN-693
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-693
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Hung Tran
>            Assignee: Hung Tran
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Add an ORC hive serde manager to register ORC datasets in Hive.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to