[ 
https://issues.apache.org/jira/browse/GOBBLIN-706?focusedWorklogId=217339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217339
 ]

ASF GitHub Bot logged work on GOBBLIN-706:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Mar/19 16:53
            Start Date: 22/Mar/19 16:53
    Worklog Time Spent: 10m 
      Work Description: ibuenros commented on pull request #2576: 
[GOBBLIN-706]enable dynamic mappers
URL: https://github.com/apache/incubator-gobblin/pull/2576#discussion_r268255215
 
 

 ##########
 File path: 
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
 ##########
 @@ -362,6 +362,15 @@ public static KafkaWorkUnitPacker getInstance(PackerType 
packerType, AbstractSou
         throw new IllegalArgumentException("WorkUnit packer type " + 
packerType + " not found");
     }
   }
+  public double getWorkUnitEstSizes(Map<String, List<WorkUnit>> 
workUnitsByTopic){
 
 Review comment:
   Is there a reason we can't just use `setWorkUnitEstSizes`? the logic in here 
is almost identical.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 217339)
    Time Spent: 40m  (was: 0.5h)

> Making KafkaSource dynamically determine the number of mapper
> -------------------------------------------------------------
>
>                 Key: GOBBLIN-706
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-706
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to