[
https://issues.apache.org/jira/browse/GOBBLIN-706?focusedWorklogId=217369&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-217369
]
ASF GitHub Bot logged work on GOBBLIN-706:
------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Mar/19 18:09
Start Date: 22/Mar/19 18:09
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2576:
[GOBBLIN-706]enable dynamic mappers
URL: https://github.com/apache/incubator-gobblin/pull/2576#discussion_r268284121
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/workunit/packer/KafkaWorkUnitPacker.java
##########
@@ -362,6 +362,15 @@ public static KafkaWorkUnitPacker getInstance(PackerType
packerType, AbstractSou
throw new IllegalArgumentException("WorkUnit packer type " +
packerType + " not found");
}
}
+ public double getWorkUnitEstSizes(Map<String, List<WorkUnit>>
workUnitsByTopic){
Review comment:
You can make the other method public. In general, it is a bad idea to have
the same logic duplicated in different locations.
Also, please add javadoc to any public methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 217369)
> Making KafkaSource dynamically determine the number of mapper
> -------------------------------------------------------------
>
> Key: GOBBLIN-706
> URL: https://issues.apache.org/jira/browse/GOBBLIN-706
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
