sv2000 commented on a change in pull request #2672: [GOBBLIN-806]Enable metrics
reporter during dataset discovery for retention job
URL: https://github.com/apache/incubator-gobblin/pull/2672#discussion_r294978810
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/profile/MultiCleanableDatasetFinder.java
##########
@@ -52,6 +53,10 @@ public MultiCleanableDatasetFinder(FileSystem fs,
Properties jobProps) {
super(fs, jobProps);
Review comment:
hmm..ok. Can't we change the super class constructor to
MultiDatasetFinder(fs, jobProps, eventSubmitter) and create the submitter in
the MultiCleanableDatasetFinder() constructor and pass it to the parent class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
