jhsenjaliya commented on issue #2683: [GOBBLIN-TBD] Adding Kafka 0.10 module, upgrading default Kafka in Gobblin URL: https://github.com/apache/incubator-gobblin/pull/2683#issuecomment-509094612 thought: should we just name the variables without version ? i.e. instead of `kafka10Client`, should we name `kafkaClient` ? since the type will anyway will have version.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
