shirshanka commented on issue #2683: [GOBBLIN-TBD] Adding Kafka 0.10 module, upgrading default Kafka in Gobblin URL: https://github.com/apache/incubator-gobblin/pull/2683#issuecomment-509356107 > thought: should we just name the variables without version ? i.e. instead of `kafka10Client`, should we name `kafkaClient` ? since the type will anyway will have version. Agreed... I was copying from the Kafka-09 module... I intend to use this exercise to figure out how we should be simplifying the act of adding a new version-specific kafka connector.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
