[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333624
]
ASF GitHub Bot logged work on GOBBLIN-924:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:04
Start Date: 24/Oct/19 18:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338715411
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##########
@@ -261,14 +250,11 @@ private void addSchemaProperties(Path path,
HiveRegistrationUnit hiveUnit)
* org.apache.hadoop.hive.serde.serdeConstants#LIST_COLUMNS and
* org.apache.hadoop.hive.serde.serdeConstants#LIST_COLUMN_TYPES
*
- * Keeping {@link #SCHEMA_LITERAL} will be a nice-to-have thing but not
actually necessary in terms of functionality.
Review comment:
Not an issue, but call out on changing the documentation as well, usually we
forget about that and leads to code smell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 333624)
Time Spent: 0.5h (was: 20m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---------------------------------------------------------------
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
