[
https://issues.apache.org/jira/browse/GOBBLIN-924?focusedWorklogId=333671&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-333671
]
ASF GitHub Bot logged work on GOBBLIN-924:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/19 18:58
Start Date: 24/Oct/19 18:58
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2780:
[GOBBLIN-924]Get rid of orc.schema.literal in ORC-ingestion and registration
URL: https://github.com/apache/incubator-gobblin/pull/2780#discussion_r338739989
##########
File path:
gobblin-hive-registration/src/main/java/org/apache/gobblin/hive/orc/HiveOrcSerDeManager.java
##########
@@ -152,18 +147,12 @@ public void addSerDeProperties(HiveRegistrationUnit
source, HiveRegistrationUnit
if (source.getOutputFormat().isPresent()) {
target.setOutputFormat(source.getOutputFormat().get());
}
- if (source.getSerDeProps().contains(SCHEMA_LITERAL)) {
- target.setSerDeProp(SCHEMA_LITERAL,
source.getSerDeProps().getProp(SCHEMA_LITERAL));
- }
}
@Override
public void updateSchema(HiveRegistrationUnit existingUnit,
HiveRegistrationUnit newUnit)
throws IOException {
- Preconditions.checkArgument(
- newUnit.getSerDeProps().contains(SCHEMA_LITERAL));
-
- existingUnit.setSerDeProp(SCHEMA_LITERAL,
newUnit.getSerDeProps().getProp(SCHEMA_LITERAL));
+ log.debug("Do nothing to update schema since orc.schema.literal is
removed");
Review comment:
I thought logging is the only thing that you did in the method, if that is
the case, there's no need to keep this overriding.
But yes updating `columns` and `column.types` should be the correct
behavior. It actually doesn't matter too much if this method is called anywhere
because it is a public method and there could be usage somewhere we have no way
to control, but still we strive to maintain backward-compatability with correct
behavior.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 333671)
Time Spent: 1h 20m (was: 1h 10m)
> Get rid of orc.schema.literal in ORC-ingestion and registration
> ---------------------------------------------------------------
>
> Key: GOBBLIN-924
> URL: https://issues.apache.org/jira/browse/GOBBLIN-924
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
