[
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337047
]
ASF GitHub Bot logged work on GOBBLIN-941:
------------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/19 21:01
Start Date: 31/Oct/19 21:01
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2790:
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341363858
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/materializer/HiveMaterializerFromEntityQueryGenerator.java
##########
@@ -118,11 +119,19 @@ public QueryBasedHivePublishEntity
generatePublishQueries() throws DataConversio
Map<String, String> publishDirectories =
publishEntity.getPublishDirectories();
List<String> cleanupQueries = publishEntity.getCleanupQueries();
List<String> cleanupDirectories = publishEntity.getCleanupDirectories();
+ Optional<Schema> avroSchema = Optional.absent();
Review comment:
I might be wrong but is this method being called through the conversion
jobs? By briefly looking at the code base, this `generatePublishQueries` method
is only called in
`org.apache.gobblin.data.management.conversion.hive.materializer.HiveMaterializer#generatePublishQueries`
which is not related to Avro2ORC, just want to confirm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 337047)
> Enhance DDL to add column and column.types with case-preserving schema
> ----------------------------------------------------------------------
>
> Key: GOBBLIN-941
> URL: https://issues.apache.org/jira/browse/GOBBLIN-941
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which
> would enforce avro2orc output preserving correct casing
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
