[jira] [Work logged] (GOBBLIN-941) Enhance DDL to add column and column.types with case-preserving schema

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/GOBBLIN-941?focusedWorklogId=337058&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-337058
 ]

ASF GitHub Bot logged work on GOBBLIN-941:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Oct/19 21:17
            Start Date: 31/Oct/19 21:17
    Worklog Time Spent: 10m 
      Work Description: ZihanLi58 commented on pull request #2790: 
[GOBBLIN-941] Enhance DDL to add column and column.types with case-preserving 
schema
URL: https://github.com/apache/incubator-gobblin/pull/2790#discussion_r341369711
 
 

 ##########
 File path: 
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/query/HiveAvroORCQueryGenerator.java
 ##########
 @@ -202,7 +204,21 @@ public static String generateCreateTableDDL(Schema schema,
     //    .. use columns from destination schema
     if (isEvolutionEnabled || !destinationTableMeta.isPresent()) {
       log.info("Generating DDL using source schema");
+      System.out.println("Generating DDL using source schema");
       ddl.append(generateAvroToHiveColumnMapping(schema, 
Optional.of(hiveColumns), true, dbName + "." + tblName));
+      try {
 
 Review comment:
   I want to make sure only when schema evolution is enabled or there is no 
existing table, we can set the columns. Because that will overwrite the schema.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 337058)
    Time Spent: 1h 40m  (was: 1.5h)

> Enhance DDL to add column and column.types with case-preserving schema
> ----------------------------------------------------------------------
>
>                 Key: GOBBLIN-941
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-941
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Zihan Li
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Enhance DDL to add column and column.types with case-preserving schema which 
> would enforce avro2orc output preserving correct casing



--
This message was sent by Atlassian Jira
(v8.3.4#803005)