[
https://issues.apache.org/jira/browse/GOBBLIN-1001?focusedWorklogId=357564&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-357564
]
ASF GitHub Bot logged work on GOBBLIN-1001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Dec/19 01:53
Start Date: 11/Dec/19 01:53
Worklog Time Spent: 10m
Work Description: autumnust commented on issue #2846: [GOBBLIN-1001]
Implement TimePartitionGlobFinder
URL:
https://github.com/apache/incubator-gobblin/pull/2846#issuecomment-564341258
> @autumnust It does use, compositely use instead of inheriting, an existing
GlobFinder, which is `DefaultFileSystemGlobFinder`.
OK Gotcha. If `enableEmptyPartition` is not enabled, it does nothing more
than just setting a different pattern using `DefaultFileSystemGlobFinder`. If
it does, it somehow creates empty dataset for yesterday's partitions. This
doesn't seem to be a generic finder to me but serving a very specific purpose.
Would you consider doing it as a separated extension for GlobFinder internally
instead of open-source?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 357564)
Time Spent: 40m (was: 0.5h)
> Implement TimePartitionGlobFinder
> ---------------------------------
>
> Key: GOBBLIN-1001
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1001
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
