[
https://issues.apache.org/jira/browse/GOBBLIN-1001?focusedWorklogId=358855&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-358855
]
ASF GitHub Bot logged work on GOBBLIN-1001:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Dec/19 19:05
Start Date: 12/Dec/19 19:05
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2846:
[GOBBLIN-1001] Implement TimePartitionGlobFinder
URL: https://github.com/apache/incubator-gobblin/pull/2846#discussion_r357312011
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/dataset/DefaultFileSystemGlobFinder.java
##########
@@ -33,16 +33,6 @@ public DefaultFileSystemGlobFinder(FileSystem fs,
Properties properties) throws
}
public FileSystemDataset datasetAtPath(final Path path) throws IOException {
- return new FileSystemDataset() {
Review comment:
There are more than one places that having this anonymous class impl. Shall
we refactor them all if you would like to replace it with the real impl. ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 358855)
Time Spent: 1h (was: 50m)
> Implement TimePartitionGlobFinder
> ---------------------------------
>
> Key: GOBBLIN-1001
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1001
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
