[
https://issues.apache.org/jira/browse/GOBBLIN-1011?focusedWorklogId=362651&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362651
]
ASF GitHub Bot logged work on GOBBLIN-1011:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 19:04
Start Date: 23/Dec/19 19:04
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2856:
[GOBBLIN-1011] adjust compaction flow to work with virtual partition
URL: https://github.com/apache/incubator-gobblin/pull/2856#discussion_r360967552
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/task/TaskIFaceWrapper.java
##########
@@ -75,6 +78,8 @@ public String getProgress() {
public void run() {
try {
this.underlyingTask.run();
+ } catch (Exception e) {
+ log.error(String.format("Task %s completed with exception",
this.taskContext.getTaskState().getTaskId()), e);
Review comment:
This seems to be an anti-pattern to catch exception if `run` method itself
is not throwing an exception here. I wonder what is the reason for this
change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362651)
Time Spent: 1h 20m (was: 1h 10m)
> Adjust compaction flow to work with virtual partition
> -----------------------------------------------------
>
> Key: GOBBLIN-1011
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1011
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> - Update existing `CompactionVerifier`s and `CompactionCompleteAction`s to
> work with virtual simple file system dataset proply
> - Improve ser/de of `FileSystemDataset` in `CompactionSuiteBase`
> - Update gobblin-hive-registration to work with table parameters properly
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
